Skip to content

Fix ACP resume for equivalent Windows workspace paths - #1923

Open
calebchongc wants to merge 1 commit into
justrach:mainfrom
calebchongc:fix/windows-acp-session-resume
Open

calebchongc wants to merge 1 commit into
justrach:mainfrom
calebchongc:fix/windows-acp-session-resume

Conversation

@calebchongc

Copy link
Copy Markdown

Summary

Resolve the active Windows workspace the same way as the saved workspace before comparing them during ACP session restore. The same checkout can be opened with a drive-letter path or an extended-length path. Saves from different checkouts are still rejected.

Fixes #1922.

Tests

  • Windows unit regression using two real directories.
  • Windows ACP reproduction against the release and rebuilt binary: equivalent paths restore and replay the save, and a different checkout still fails.

The full local suite was run on Windows and WSL. Windows reported failures outside the resume regression. Both WSL unit failures reproduced on the unmodified base. Formatting, conformance and test reachability passed on WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACP session restore rejects equivalent Windows extended-length workspace paths

1 participant