Repository navigation
Fix ACP resume for equivalent Windows workspace paths - #1923
Open
calebchongc wants to merge 1 commit into
Open
calebchongc wants to merge 1 commit into
calebchongc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the active Windows workspace the same way as the saved workspace before comparing them during ACP session restore. The same checkout can be opened with a drive-letter path or an extended-length path. Saves from different checkouts are still rejected.
Fixes #1922.
Tests
The full local suite was run on Windows and WSL. Windows reported failures outside the resume regression. Both WSL unit failures reproduced on the unmodified base. Formatting, conformance and test reachability passed on WSL.